[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 23/28] cputest: Switch host CPU data scripts to model expansion



On Thu, Feb 23, 2017 at 03:15:21PM +0100, Jiri Denemark wrote:
> Instantiating "host" CPU and querying it using qom-get has been the only
> way of probing host CPU via QEMU until 2.9.0 implemented
> query-cpu-model-expansion for x86_64. Even though libvirt never really
> used the old way its result can be easily converted into the one
> produced by query-cpu-model-expansion. Thus we can reuse the original
> test data and possible get new data from hosts where QEMU does not
> support the new QMP command.
> 
> Signed-off-by: Jiri Denemark <jdenemar redhat com>
> ---
> 
> Notes:
>     Version 3:
>     - no change
>     
>     Version 2:
>     - cpu-convert.py: set "vendor" property according to model-id
> 
>  tests/cputestdata/cpu-convert.py | 249 +++++++++++++++++++++++++++++++++++++++
>  tests/cputestdata/cpu-gather.sh  |  39 +++++-
>  tests/cputestdata/cpu-parse.sh   |   3 +
>  3 files changed, 285 insertions(+), 6 deletions(-)
>  create mode 100755 tests/cputestdata/cpu-convert.py
> 
> diff --git a/tests/cputestdata/cpu-convert.py b/tests/cputestdata/cpu-convert.py
> new file mode 100755
> index 000000000..77bae3628
> --- /dev/null
> +++ b/tests/cputestdata/cpu-convert.py
> @@ -0,0 +1,249 @@
> +#!/usr/bin/python

It's better to specify python version, in this case python2.

ACK

Pavel

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]