[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH v2 REBASE 00/18] Introduce vGPU mdev framework to libvirt



On Mon, 20 Feb 2017 15:28:13 +0100
Erik Skultety <eskultet redhat com> wrote:

> since the original v2 [1]:
> - resolved a few merge conflicts caused by @9d92f533 which refactored out some
> duplicate code which eventually lead to dropping patch 14/18 from the original
> series due to being unnecessary
> - rebased onto fresh HEAD
> 
> [1] https://www.redhat.com/archives/libvir-list/2017-February/msg00739.html
> 
> Erik Skultety (18):
>   util: Introduce new module virmdev
>   conf: Introduce new hostdev device type mdev
>   conf: Introduce new address type mdev
>   conf: Update XML parser, formatter, and RNG schema to support mdev
>   conf: Introduce virDomainHostdevDefPostParse
>   conf: Add post parse code for mdevs to virDomainHostdevDefPostParse
>   security: dac: Enable labeling of vfio mediated devices
>   security: selinux: Enable labeling of vfio mediated devices
>   conf: Enable cold-plug of a mediated device
>   qemu: Assign PCI addresses for mediated devices as well
>   hostdev: Maintain a driver list of active mediated devices
>   hostdev: Introduce a reattach method for mediated devices
>   qemu: cgroup: Adjust cgroups' logic to allow mediated devices
>   qemu: Bump the memory locking limit for mdevs as well
>   qemu: Format mdevs on qemu command line
>   test: Add some test cases for our test suite regarding the mdevs
>   docs: Document the new hostdev and address type 'mdev'
>   news: Update the NEWS.xml about the new mdev feature
> 
>  docs/formatdomain.html.in                          |  48 ++-
>  docs/news.xml                                      |   9 +
>  docs/schemas/domaincommon.rng                      |  26 ++
>  po/POTFILES.in                                     |   1 +
>  src/Makefile.am                                    |   1 +
>  src/conf/device_conf.h                             |   1 +
>  src/conf/domain_conf.c                             | 203 ++++++++++--
>  src/conf/domain_conf.h                             |   9 +
>  src/libvirt_private.syms                           |  20 ++

I don't understand how these get generated, so I won't suggest where
they should be added, but a usb test fails for me without adding
these to this syms file:

+virMediatedDeviceModelTypeFromString;
+virMediatedDeviceModelTypeToString;

Thanks,
Alex

>  src/qemu/qemu_command.c                            |  49 +++
>  src/qemu/qemu_command.h                            |   5 +
>  src/qemu/qemu_domain.c                             |  23 +-
>  src/qemu/qemu_domain.h                             |   1 +
>  src/qemu/qemu_domain_address.c                     |  16 +-
>  src/qemu/qemu_hostdev.c                            |  37 +++
>  src/qemu/qemu_hostdev.h                            |   8 +
>  src/qemu/qemu_hotplug.c                            |   2 +
>  src/security/security_apparmor.c                   |   3 +
>  src/security/security_dac.c                        |  55 ++++
>  src/security/security_selinux.c                    |  54 ++++
>  src/util/virhostdev.c                              | 229 ++++++++++++-
>  src/util/virhostdev.h                              |  16 +
>  src/util/virmdev.c                                 | 358 +++++++++++++++++++++
>  src/util/virmdev.h                                 |  93 ++++++
>  tests/domaincapsschemadata/full.xml                |   1 +
>  .../qemuxml2argv-hostdev-mdev-unmanaged.args       |  25 ++
>  .../qemuxml2argv-hostdev-mdev-unmanaged.xml        |  37 +++
>  tests/qemuxml2argvtest.c                           |   6 +
>  .../qemuxml2xmlout-hostdev-mdev-unmanaged.xml      |  40 +++
>  tests/qemuxml2xmltest.c                            |   1 +
>  30 files changed, 1333 insertions(+), 44 deletions(-)
>  create mode 100644 src/util/virmdev.c
>  create mode 100644 src/util/virmdev.h
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-unmanaged.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-mdev-unmanaged.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-mdev-unmanaged.xml
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]