[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH v2 REBASE 03/18] conf: Introduce new address type mdev



On Mon, Feb 20, 2017 at 03:28:16PM +0100, Erik Skultety wrote:
> Since the address element is much easier extendible by attributes adding
> more and more elements, starting with <uuid>, to the <source> element
> once we find out we need more data to identify a mediated device. By
> introducing a new address type rather than using plain elements, we also
> remain consistent with all other devices that can make use of the
> address element.
> 
> Signed-off-by: Erik Skultety <eskultet redhat com>
> ---
>  src/conf/device_conf.h |  1 +
>  src/conf/domain_conf.c | 11 +++++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)

ACK to the code, however I think that this patch should be placed before
"[PATCH 02/18] conf: Introduce new hostdev device type mdev".

Pavel

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]