[libvirt] [PATCH 0/2] Attempt, and fail, to fix build with Clang 3.9 / Linux

[Andrea Bolognani]

Martin asked for this a while ago. I was surprised, at first,
because according to my experience the only issue with Clang
builds were a couple of test cases failing to run, but trying
again on Clang 3.9 / Fedora rawhide caused me to run into at
least three separate compilation issues.

Two of them I take care with this series, even though I'm
fairly unconvinced the bugs are actually in libvirt rather
than Clang or glibc; more details in the relevant commit
messages.

The last one I was unable to work around in any sensible
manner: when linking, clang fails with

  ../gnulib/lib/.libs/libgnu.a(mgetgroups.o):
  In function `realloc_groupbuf':
  .../libvirt/gnulib/lib/mgetgroups.c:45:
  undefined reference to `__muloti4'

This seems to be a well-known issue[1] with no solution in
sight; passing CFLAGS='-rtlib=compiler-rt' to configure
allows the compilation to succeed but, yeah, way gross.

So basically I've spent way too much time trying to get this
to work and I'm stuck now, so I'm posting whatever I have so
far in hope others will pitch in and help me out :)


[1] https://llvm.org/bugs/show_bug.cgi?id=16404

Andrea Bolognani (2):
  util: Turn virFirewallAddRule() into a macro
  util: Cast to 'long double' when calling isnan()

 src/libvirt_private.syms |  1 -
 src/util/virfirewall.c   | 23 -----------------------
 src/util/virfirewall.h   | 16 ++++++++++++----
 src/util/virxml.c        | 10 +++++-----
 4 files changed, 17 insertions(+), 33 deletions(-)

-- 
2.11.0