[libvirt] [PATCH 1/9] Add domain event for metadata changes

Daniel P. Berrange berrange at redhat.com
Fri Jan 6 15:09:49 UTC 2017


On Fri, Jan 06, 2017 at 04:02:44PM +0100, Michal Privoznik wrote:
> On 01/05/2017 02:59 PM, Daniel P. Berrange wrote:
> > When changing the metadata via virDomainSetMetadata, we now
> > emit an event to notify the app of changes. This is useful
> > when co-ordinating different applications read/write of
> > custom metadata.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > ---
> >  daemon/remote.c                     | 45 +++++++++++++++++++
> >  examples/object-events/event-test.c | 35 +++++++++++++++
> >  include/libvirt/libvirt-domain.h    | 20 +++++++++
> >  src/bhyve/bhyve_driver.c            |  7 +++
> >  src/conf/domain_event.c             | 86 +++++++++++++++++++++++++++++++++++++
> >  src/conf/domain_event.h             | 10 +++++
> >  src/libvirt_private.syms            |  2 +
> >  src/lxc/lxc_driver.c                |  6 +++
> >  src/qemu/qemu_driver.c              |  6 +++
> >  src/remote/remote_driver.c          | 33 +++++++++++++-
> >  src/remote/remote_protocol.x        | 15 ++++++-
> >  src/remote_protocol-structs         |  7 +++
> >  src/test/test_driver.c              |  6 +++
> >  tools/virsh-domain.c                | 25 +++++++++++
> >  14 files changed, 301 insertions(+), 2 deletions(-)
> > 
> 
> > diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> > index 46da06f..c161a56 100644
> > --- a/src/remote/remote_driver.c
> > +++ b/src/remote/remote_driver.c
> 
> > @@ -5121,7 +5130,7 @@ remoteDomainBuildEventCallbackDeviceRemovalFailed(virNetClientProgramPtr prog AT
> >                                                    void *evdata, void *opaque)
> >  {
> >      virConnectPtr conn = opaque;
> > -    remote_domain_event_callback_device_added_msg *msg = evdata;
> > +    remote_domain_event_callback_device_removal_failed_msg *msg = evdata;
> >      struct private_data *priv = conn->privateData;
> >      virDomainPtr dom;
> >      virObjectEventPtr event = NULL;
> 
> Some purists on the list might tell you to put this into a separate
> commit. I'm not one of them :-)

Actually I did mean todo that, but forgot 

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|




More information about the libvir-list mailing list