[libvirt] [PATCH 0/2] replacement for Patches 5/8 & 6/8 of "aggregate multiple pcie-root-ports onto a single slot"

Laine Stump laine at laine.org
Tue Jan 10 08:23:01 UTC 2017


During review of the aforementioned series, Andrea expressed
misgivings about patch 6, which automatically set the multifunction=on
option transiently at the time the qemu commandline was generated. Dan
agreed. These two patches replace patches 5 and 6 of that series with
two patches that will set multi='on' in the domain's config rather
than just temporarily in the commandline. This way it will remain set
even if all the devices on the non-0 function are later removed
(unless it's explicitly changed by the user/management app, that is).

The rest of the series is ACKed and ready to push, which I'd like to
do before the freeze on Wednesday; these two patche are all that's
holding it up.

Laine Stump (2):
  conf: new function virDomainPCIAddressSetAllMulti()
  qemu: use virDomainPCIAddressSetAllMulti() to set multi when needed

 src/conf/domain_addr.c                             |  75 +++++++++++++
 src/conf/domain_addr.h                             |   4 +
 src/libvirt_private.syms                           |   1 +
 src/qemu/qemu_domain_address.c                     |   5 +
 .../qemuxml2argv-q35-multifunction.args            |  42 ++++++++
 .../qemuxml2argv-q35-multifunction.xml             |  51 +++++++++
 tests/qemuxml2argvtest.c                           |  23 ++++
 .../qemuxml2xmlout-q35-multifunction.xml           | 120 +++++++++++++++++++++
 tests/qemuxml2xmltest.c                            |  23 ++++
 9 files changed, 344 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-multifunction.xml

-- 
2.7.4




More information about the libvir-list mailing list