[libvirt] [PATCH 1/3] Revert "storage: For FS pool check for properly formatted target volume"

[Peter Krempa]

On Thu, Jan 12, 2017 at 09:36:01 -0500, John Ferlan wrote:
> 
> 
> On 01/12/2017 09:24 AM, Peter Krempa wrote:
> > The check does not work properly (crashes) with netfs filesystems and
> > also checking that a device is not empty when attempting to mount a
> > filesystem is not very usefull since the mount will fail anyways.
> > 
> > As the code would improve only a very minor corner case I don't really
> > see a reason to have this code at all.
> > 
> > This code would also fail if libvirt is compiled without support for
> > blkid and without parted.
> > 
> > This reverts commit a11fd69735e6951cda9bf256d8e423696a441aa4.
> > ---
> >  src/storage/storage_backend_fs.c | 13 ++-----------
> >  1 file changed, 2 insertions(+), 11 deletions(-)
> > 
> 
> Instead of reverting why not just fix the issue.

Because I think the whole check is pointless. It's valid only when
mounting a local filesystem, and in that case basically the same check
is done when mounting the filesystem by the kernel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170112/8f8dc899/attachment-0001.sig>