[libvirt] [PATCH v3 0/4] Virtio-crypto device support

[Boris Fiuczynski]

On 07/06/2017 03:47 PM, Longpeng (Mike) wrote:
> Hi Boris,
> 
> On 2017/7/6 20:28, Boris Fiuczynski wrote:
> 
>> Hi Mike,
>> I am going to send a set of patches based on your series adding ccw support
>> since your patch series contains only pci support.
>> Feel free to include or append my patches (in)to your series.
>>
> 
> Okay :)  you can send your patches to me or to mail-list, and I'll including
> your patches in v4.
> 
>> libvirt contributor guidelines now require to update docs/news.xml and note that
>> the change has to be in a separate patch. virtio-crypto should be listed in the
>> "New features" section.
>>
> 
> I see, thanks.
> 
>> I also noticed build errors after applying patch 3 due to missing capabilities
>> in the test xmls
>> tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml  (located in patch 4)
>> tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml  (missing)
>> tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml   (located in patch 4)
>>
> 
> I'll add the missing part :)
> 
>> I suggest to put the introduction of the capabilities "cryptodev-
>> backend-builtin" and "virtio-crypto" including the changes in tests in a
>> separate patch.
>>
> 
> Sorry, I don't quite understand this, could you explain it in detail?
Put the required changes for the capabilities in files

tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h

into one separate patch. Does that explain it better?

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294