[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml



On Fri, 2017-07-07 at 12:48 +0200, Peter Krempa wrote:
> > qemuxml2argv already supports the ability to include test
> > cases that are known not to make it past
XML parsing, and
> > since we want to keep qemuxml2xml in sync with it as much
> > as possible, we need to implement this missing feature.
> 
> I must say that I
don't really see the point to have them fail twice ...
> 
> I'd understand if this would be added to the genericxml2xmltest (if it's
> not there)

We have a lot of test cases with xml2argv coverage but no
xml2xml coverage, and vice versa. The obvious solution to
that is to, in due time, make it so you only need to list
input file and capabilities once to have them tested both
for xml2argv and xml2xml, and this is a step towards that
still pretty far away goal.

> > @@ -217,6 +231,17 @@ testCompareStatusXMLToXMLFiles(const void *opaque)
> >  
> >      ret = 0;
> >  
> > + ok:
> 
> This is not an okay name for a label.

It's clearly an "ok" name though :P

I borrowed it from testCompareXMLToArgv() in xml2argv,
but I don't have a problem changing it to something you
think is more suitable.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]