[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/12] qemu: command: Remove old style -parallel building



On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
> AFAIK there aren't any qemu arch/machine types with platform parallel
> devices that would require old style -parallel config, so we shouldn't
> ever need this nowadays.
> 
> Remove a now redundant test
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/qemu/qemu_command.c                            | 33 ++++++++------------
>  .../qemuxml2argv-parallel-tcp.args                 | 22 --------------
>  .../qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml | 35 ----------------------
>  tests/qemuxml2argvtest.c                           |  1 -
>  tests/qemuxml2xmltest.c                            |  1 -
>  5 files changed, 12 insertions(+), 80 deletions(-)
>  delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.args
>  delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml

Under the assumption that you've done your homework and
confirmed that bumping the minimium supported QEMU version
has made this unnecessary,

Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]