[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/12] qemu: support chardev for all machvirt config



On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
> Drew pointed out that we can use -chardev with machvirt platform
> serial devices like:
> 
>   -chardev pty,id=foo
>   -serial chardev:foo
> 
> And indeed it looks like qemu has supported this for as long as -chardev
> has been around. Wiring this up will enable all the modern -chardev
> features for every machvirt config (and some other arch/machine types).
> 
> However just enabling that change is going to cause a lot of unneeded
> test suite churn, due to the fact that some code is still checking for
> qemu -chardev support, even though our minimum qemu version always has
> chardev nowadays. So take the opportunity to exorcise QEMU_CAPS_CHARDEV
> 
> * Patch 1 reverts Christopher's recent patch, to unbreak existing configs
> * Patch 2-3 make pci-serial work for machvirt and demonstrate it with a
>   test suite change.
> * Patch 4-10 slowly strip out QEMU_CAPS_DEVICE
> * Patch 11 adds -chardev support for platform serial devices
> * Patch 12 is a cleanup

Things that I forgot to mention during review:

  * patch 11/12 fixes [1], a fact that should be mentioned
    in the commit message;

  * you need to update the release notes as well.

Thanks for taking on this! :)


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1435681
-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]