[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 2/6] fdstream: Report error from the I/O thread




On 06/22/2017 08:30 AM, Michal Privoznik wrote:
> Problem with our error reporting is that the error object is a
> thread local variable. That means if there's an error reported
> within the I/O thread it gets logged and everything, but later
> when the event loop aborts the stream it doesn't see the original
> error. So we are left with some generic error. We can do better
> if we copy the error message between the threads.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  daemon/stream.c        | 18 ++++++++++++------
>  src/util/virfdstream.c |  9 ++++++---
>  2 files changed, 18 insertions(+), 9 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]