[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/5] Misc cleanups for internal.h & fix tests with CLang



On Wed, 2017-07-05 at 12:58 +0100, Daniel P. Berrange wrote:
> When writing the fix for test suite mocking under CLang I found a
> bunch of cruft in internal.h The first four patches thus cleanup
> up internal.h. We then add the extra annotations requird to prevent
> CLang optimizer breaking mock overrides.

A very minor detail that I feel compelled to point out
regardless: it's Clang, not CLang. Please use the proper
capitalization, if not in the commit messages at the very
least in the error messages you introduce in patch 2/5.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]