[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml



On Fri, 2017-07-07 at 13:15 +0200, Peter Krempa wrote:
> > that is to, in due time, make it so you only need to list
> > input file and capabilities once to have them tested both
> > for xml2argv and xml2xml, and this is a step towards that
> > still pretty far away goal.
> 
> This is certainly a good worthwhile goal. I just don't really see how
> splitting the testing of unparsable documents into two places or
> duplicating it will help your effort to simplify it.

For some reason I was convinced that having the test in both
files would make the task of unifying the list down the line
easier, which is of course complete rubbish.

So forget this patch ever existed. I'll add the test case to
genericxml2xmltest instead, as you suggested.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]