[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/9] util: json: Properly implement JSON deflattening




On 06/27/2017 08:46 AM, Peter Krempa wrote:
> As it turns out sometimes users pass in an arbitrarily nested structure
> e.g. for the qemu backing chains JSON pseudo protocol. This new
> implementation deflatens now a single object fully even with nested

deflattens

> keys.
> 
> Additionally it's not necessary now to stick with the "file." prefix for
> the properties.
> ---
>  src/util/virjson.c                                 | 67 ++++++++++++++++------
>  tests/virjsondata/deflatten-basic-generic-out.json | 20 +++++++
>  .../deflatten-concat-double-key-out.json           |  9 ---
>  tests/virjsondata/deflatten-concat-out.json        |  7 +--
>  tests/virjsondata/deflatten-deep-file-out.json     | 24 ++++++--
>  tests/virjsondata/deflatten-deep-generic-out.json  | 27 +++++++++
>  tests/virjsondata/deflatten-double-key-out.json    |  6 --
>  tests/virjsontest.c                                |  8 +--
>  8 files changed, 121 insertions(+), 47 deletions(-)
>  create mode 100644 tests/virjsondata/deflatten-basic-generic-out.json
>  delete mode 100644 tests/virjsondata/deflatten-concat-double-key-out.json
>  create mode 100644 tests/virjsondata/deflatten-deep-generic-out.json
>  delete mode 100644 tests/virjsondata/deflatten-double-key-out.json
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]