[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/19] test: Cleanup exit/failure paths of some storage pool APIs



On Tue, May 09, 2017 at 11:30:10AM -0400, John Ferlan wrote:
> Rework some of the test driver API's to remove the need to return failure
> when testStoragePoolObjFindByName returns NULL rather than going to cleanup.
> This removes the need for check for "if (obj)" and in some instances the
> need to for a cleanup label and a local ret variable.

The recommended wrapping of commit message body is 72 columns.

> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/test/test_driver.c | 49 ++++++++++++++++---------------------------------
>  1 file changed, 16 insertions(+), 33 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]