[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: increase libnl buffer size to 1M



On Mon, Jul 10, 2017 at 02:51:34PM -0400, John Ferlan wrote:
> 
> 
> On 06/29/2017 02:05 PM, ZhiPeng Lu wrote:
> > nl_recv() returns the error "No buffer space available"
> > when using virsh destroy domain with 240 or more
> > passhthrough network interfaces.
> 
> pass-through
> 
> > The patch increases libnl sock receive buffer size to 1M,
> > and nl_recv() doesn't return error when destroying domain
> > with 512 network interfaces.
> > 
> > Signed-off-by: ZhiPeng Lu <lu zhipeng zte com cn>
> > ---
> >  src/util/virnetlink.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> This feels like something that perhaps should be configurable - that is
> some /etc/libvirt/libvirtd.conf variable; otherwise, we'll keep hitting
> some conflated maximum based on the size of something.

1 MB matches what systemed/udevd uses, so if we hit that limit, then  the
system as a whole is going to struggle already. So I don't think we need
make it configurable.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]