[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 9/9] tests: Validate that JSON deflattening fixed nested json pseudo-protocol strings



On Mon, Jul 10, 2017 at 10:01:30 -0400, John Ferlan wrote:
> 
> 
> On 06/27/2017 08:46 AM, Peter Krempa wrote:
> > Sheepdog and possibly others use nested objects for network server and
> > thus could be specified in a way that libvirt would not parse.
> > 
> > Validates that https://bugzilla.redhat.com/show_bug.cgi?id=1464821
> > is fixed properly.
> > ---
> >  tests/virjsondata/deflatten-qemu-sheepdog-in.json  | 11 +++++++++++
> >  tests/virjsondata/deflatten-qemu-sheepdog-out.json | 13 +++++++++++++
> >  tests/virjsontest.c                                |  1 +
> >  tests/virstoragetest.c                             | 10 ++++++++++
> >  4 files changed, 35 insertions(+)
> >  create mode 100644 tests/virjsondata/deflatten-qemu-sheepdog-in.json
> >  create mode 100644 tests/virjsondata/deflatten-qemu-sheepdog-out.json
> > 
> 
> Reviewed-by: John Ferlan <jferlan redhat com>

Thanks for the review, I've implemented your suggestions and pushed the
patches.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]