[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Provide non-linux stub for qemuDomainAttachDeviceMknodRecursive



On Tue, Jul 11, 2017 at 06:42:29PM +0200, Michal Privoznik wrote:
> The way we create devices under /dev is highly linux specific.
> For instance we do mknod(), mount(), umount(), etc. Some
> platforms are even missing some of these functions. Then again,
> as declared in qemuDomainNamespaceAvailable(): namespaces are
> linux only. Therefore, to avoid obfuscating the code by trying to
> make it compile on weird platforms, just provide a non-linux stub
> for qemuDomainAttachDeviceMknodRecursive(). At the same time,
> qemuDomainAttachDeviceMknodHelper() which actually calls the
> non-existent functions is moved under ifdef __linux__ block since
> its only caller is in that block too.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_domain.c | 38 ++++++++++++++++++++++++++++++--------
>  1 file changed, 30 insertions(+), 8 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]