On Wed, Jul 12, 2017 at 23:13:58 -0400, Liang Yan wrote: > > > On 7/12/17 2:49 AM, Peter Krempa wrote: > > On Tue, Jul 11, 2017 at 21:33:49 -0600, Liang Yan wrote: > >> It may be better to check virtio-scsi controller first since it is > >> supported better in qemu level. > > This is not true for OS support. The old controller usually has drivers > > shipped with the system, whereas you need to install drivers separately > > for virtio-scsi. > That is fair, I only thought limited distro this time, my bad, :) > We do have some issues recently that attach passthrough lun device could > work well with virtio-scsi controller but not lsi controller, we > thought it may be better to set a specif controller for "attach-disk" > here, what do you say? Do you think is it necessary to add an extra You need to do this as a separate step. The attach-disk (and the virDomainAttachDevice API) add the controller only if necessary. If you manually add a controller of the correct type beforehand, you have full control what the type is before. > parameter or just fine-grain support for "-targetbus" that could support > specific type? or another solution that I missed? I would be glad to > implement it. I don't think it's necessary. It's only necessary to plug the controller in before adding the disk if you require the non-default one.
Description: PGP signature