[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code



>      /* Populate with known devices */
>

This commentary should stay with the function it describes (below), so the
context doesn't get lost.

Erik

> +    nodeDeviceUnlock();

>      if (udevEnumerateDevices(udev) != 0)
>          goto cleanup;
>
> -    ret = 0;
> +    return 0;
>
>   cleanup:
>      nodeDeviceUnlock();
> -
> -    if (ret == -1)
> -        nodeStateCleanup();
> -    return ret;
> +    nodeStateCleanup();
> +    return -1;
>  }
>
>
> --
> 2.9.4
>
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]