[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/17] nwfilter: Add @def into virNWFilterObjNew



On 06/02/2017 12:25 PM, John Ferlan wrote:
> Modify the virNWFilterObjNew to take @def as a parameter and consume it.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/conf/virnwfilterobj.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)

As I've stated in the other review for secret patch set, I don't see
much value in this patch. What your reasoning for it? We don't usually
do it this way.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]