[libvirt] Xen device section defaults miss name='qemu'

[Jim Fehlig]

On 07/12/2017 09:35 AM, Christian Ehrhardt wrote:
> ​Not sure how stupid it might be so clearly just a very humble RFC, but the 
> following seems to work for me:
> Therefore no nicely polished patch, but just inline diff
> 
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -367,8 +367,9 @@
>           int actual_type = virStorageSourceGetActualType(disk->src);
>           int format = virDomainDiskGetFormat(disk);
> -        /* for network-based disks, set 'qemu' as the default driver */
> -        if (actual_type == VIR_STORAGE_TYPE_NETWORK) {
> +        /* for network-based disk and cdrom, set 'qemu' as the default driver */
> +        if (actual_type == VIR_STORAGE_TYPE_NETWORK ||
> +            disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) {
>               if (!virDomainDiskGetDriver(disk) &&
>                   virDomainDiskSetDriver(disk, "qemu") < 0)
>                   return -1;

This might be useful regardless of the answer to my question about the 
disk/driver/@name attribute. AFAIK, the only backend in Xen that supports CDROM 
is qemu.

> Opinions?
> If it seems remotely reasonable I'm totally fine submitting a patch in more 
> style with proper headers and such.

Unless my statement above is incorrect, I think submitting a formal patch would 
be fine.

Regards,
Jim