[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] qemu: command: explicitly error for non-x86 default CPU



On 07/15/2017 12:40 PM, Andrea Bolognani wrote:
> On Fri, 2017-07-14 at 19:43 -0400, Cole Robinson wrote:
>> The code only currently handles writing an x86 default -cpu
>> argument, and doesn't know anything about other architectures.
>> Let's make this explicit rather than leaving ex. qemu ppc64 to
>> throw an error about -cpu qemu64
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
> 
> This seems to also fix
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=1235511
> 
> I'll review the series early next week.
> 

Thanks, but I don't think it will fix pmu=on for ppc64, just improve the error
scenario. We will still need to extend the code to hardcode the default CPU
model for PPC64 (would be nice if qemu had a generic 'default' value to use
here, or some way to get around specifying a cpu model)

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]