[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] tests: switch libxlxml2domconfig test to use testXLInintCaps



On 07/03/2017 09:03 PM, Marek Marczykowski-Górecki wrote:
As name suggests, it's a better choice for libxl test. Important
differences:
  - advertise x86_64 guests support
  - initialize host CPU caps

Signed-off-by: Marek Marczykowski-Górecki <marmarek invisiblethingslab com>
---
Changes since v1:
  - new patch, applicable over Jim's test suite for libxl_domain_config
    generator

Cc: Jim Fehlig <jfehlig suse com>
---
  tests/libxlxml2domconfigdata/basic-pv.xml | 2 +-
  tests/libxlxml2domconfigtest.c            | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/libxlxml2domconfigdata/basic-pv.xml b/tests/libxlxml2domconfigdata/basic-pv.xml
index b3bc601..eba3cc6 100644
--- a/tests/libxlxml2domconfigdata/basic-pv.xml
+++ b/tests/libxlxml2domconfigdata/basic-pv.xml
@@ -6,7 +6,7 @@
    <vcpu>4</vcpu>
    <bootloader>pygrub</bootloader>
    <os>
-    <type arch='i686' machine='xenpv'>linux</type>
+    <type arch='x86_64' machine='xenpv'>linux</type>
    </os>
    <clock offset='utc'/>
    <on_poweroff>destroy</on_poweroff>
diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
index d943cf2..ecdb1fe 100644
--- a/tests/libxlxml2domconfigtest.c
+++ b/tests/libxlxml2domconfigtest.c
@@ -173,7 +173,7 @@ mymain(void)
          return EXIT_FAILURE;
      }
- if ((xencaps = testXenCapsInit()) == NULL)
+    if ((xencaps = testXLInitCaps()) == NULL)
          return EXIT_FAILURE;

This patch looks like it could be squashed into "libxl: Add a test suite for libxl_domain_config generator".

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]