[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] security: apparmor: Properly link with storage driver in helper program



On Tue, Jul 18, 2017 at 18:35:55 +0200, Christian Ehrhardt wrote:
> On Tue, Jul 18, 2017 at 12:51 PM, Peter Krempa <pkrempa redhat com> wrote:
> 
> > The refactor to split up storage driver into modules broke the apparmor
> > helper program, since that did not initialize the storage driver
> > properly and thus detection of the backing chain could not work.
> >
> > Register the storage driver backends explicitly. Unfortunately it's now
> > necessary to link with the full storage driver to satisfy dependencies
> > of the loadable modules.
> >
> >
> Hi I tested:
> - on master direct virt-aa-helper calls
> - on Ubuntu+patch direct virt-aa-helper calls
> - on Ubuntu+patch start of confined guest with disks that have BackingStores
> - built for all architectures Ubuntu's libvirt supports (amd64 arm64 armhf
> i386 ppc64el s390x)
> 
> All worked thanks to the patch (which was created in response to [1])
> Please pick commit tags as you consider appropriate, I guess you won't need
> all three, but I happily give them all to you :-)
> Thanks a lot Peter!

No problem :) Sorry for breaking it in the first place.

> 
> Acked-by: Christian Ehrhardt <christian ehrhardt canonical com>

I tweaked this to the more commonly used "Reviewed-by"

> Reported-by: Christian Ehrhardt <christian ehrhardt canonical com>
> Tested-by: Christian Ehrhardt <christian ehrhardt canonical com>

and pushed this patch.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]