[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libvirt-domain.h: Fix enum description placement



On Fri, Jul 21, 2017 at 14:42:05 +0100, Daniel P. Berrange wrote:
> On Fri, Jul 21, 2017 at 03:00:20PM +0200, Martin Kletzander wrote:

> > struct meh {
> >       /*# This is comment for the following member foo */
> >       unsigned int foo;
> >       int bar; /*< This is for member bar that's on the same line */
> > }
> > 
> > and so on.  If that doesn't help either and it never worked,
> > then... it's a pity :-/
> 
> That is ambiguous - without seeing whitespace, the parser cannot
> distinguish between these two scenarios:
> 
>  struct meh {
>        unsigned int foo; /*# This is comment for the following member foo */
>        int bar;
>  }

Martin suggested < to be used instead of # for this type of comments to
remove the ambiguity.

>  struct meh {
>        unsigned int foo;
>        
>         /*# This is comment for the following member foo */
>        int bar;
>  }

However, I think we could just simply force using only comments above
each member in our public header files and fix the generator to properly
work with them. This should be a lot easier than fixing it to handle
both options.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]