[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/3] implement migrate-getmaxdowntime command



On Mon, Jul 24, 2017 at 11:21:43 -0500, seg us ibm com wrote:
> 
> 
> Currently, the maximum tolerable downtime for a domain being migrated is
> write-only. This patch implements a way to query that value nondestructively.
> 
> Changes from [v1]:
> 
>     * Fixed formatting and style problems
>     * Add additional JSON error check 
>     * Better patch submission mail, I hope
> 
> [v1} https://www.redhat.com/archives/libvir-list/2017-July/msg00908.html
> 
> Scott Garfinkle (3):
>     migrate-getmaxdowntime command qemu side
>     migrate-getmaxdowntime public symbols and table indices
>     migrate-getmaxdowntime local/libvirt enablement

I only skimmed through this series, so only a few high level notes:

The series is supposed to successfully compile after each patch, which
means you need to shuffle the code between patches a bit. The public
API, RPC protocol, and driver-hypervisor.h changes should go first. The
two additional patches can go in any order, either qemu implementation
first followed by virsh changes or you can change virsh first. However,
migrate-getmaxdowntime is a virsh command, the patch subjects should
really talk about the API name instead. So, for example:

    1/3 Add virDomainMigrateGetMaxDowntime public API
    2/3 qemu: Implement virDomainMigrateGetMaxDowntime
    3/3 virsh: Add support for virDomainMigrateGetMaxDowntime

In the qemu driver we already have a monitor API for querying migration
parameters (qemuMonitorJSONGetMigrationParams) and we should extend it
to support downtime-limit rather than adding a new monitor API.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]