[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/4] More virsecretobj changes to prepare for common object



ping ?  I think most of this was agreed to in the previous version -
it's just the posting and ordering...

The only minor "code" differences are in patch 1 and 3.

Tks -

John

On 07/14/2017 10:04 AM, John Ferlan wrote:
> v1: https://www.redhat.com/archives/libvir-list/2017-June/msg00168.html
> 
> but review was done more recently in 2017-July...
> 
> Changes since v1...
> 
>  ... Pushed v1 patches 1-3 since they were ACK'd
>  ... Altered old patch 4, new patch 1 to use if/else processing
>  ... Altered old patch 5, new patch 2 to account for merge conflict
>      (old patch 5 was ACK'd)
>  ... Dropped old patch 6
>  ... Altered old patch 7, new patch 3 to use VIR_STEAL_PTR and updated
>      the commit message to also describe the @def usage problem
>  ... Altered old patch 8, new patch 4 to change the commit message to
>      have more details
> 
> John Ferlan (4):
>   secret: Clean up virSecretObjListAdd processing
>   secret: Remove need for local configFile and base64File in ObjectAdd
>   secret: Properly handle @def after virSecretObjAdd in driver
>   secret: Handle object list removal and deletion properly
> 
>  src/conf/virsecretobj.c    | 53 ++++++++++++++++++++--------------------------
>  src/secret/secret_driver.c | 28 ++++++++++++++----------
>  2 files changed, 40 insertions(+), 41 deletions(-)
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]