[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Move machineName generation from virsystemd into domain_conf



On 07/24/2017 04:09 PM, Martin Kletzander wrote:
> It is more related to a domain as we might use it even when there is
> no systemd and it does not use any dbus/systemd functions.  In order
> not to use code from conf/ in util/ pass machineName in cgroups code
> as a parameter.  That also fixes a leak of machineName in the lxc
> driver and cleans up and de-duplicates some code.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  src/conf/domain_conf.c   | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h   |  5 ++++
>  src/libvirt_private.syms |  2 +-
>  src/lxc/lxc_cgroup.c     |  5 +---
>  src/lxc/lxc_domain.c     | 19 +++++++++++++++
>  src/lxc/lxc_domain.h     |  3 +++
>  src/lxc/lxc_process.c    | 25 +++++++++----------
>  src/qemu/qemu_cgroup.c   | 24 ++++---------------
>  src/qemu/qemu_domain.c   | 21 ++++++++++++++++
>  src/qemu/qemu_domain.h   |  3 +++
>  src/qemu/qemu_process.c  |  6 +++++
>  src/util/vircgroup.c     | 15 ++++--------
>  src/util/vircgroup.h     | 14 +++++------
>  src/util/virsystemd.c    | 62 ------------------------------------------------
>  src/util/virsystemd.h    |  5 ----
>  tests/virsystemdtest.c   |  4 ++--
>  16 files changed, 153 insertions(+), 122 deletions(-)

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]