[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: we prefer C89 comment styles over C99



On Tue, Jul 25, 2017 at 11:14:10PM +0200, Pavel Hrdina wrote:
Introduced by commit 'a7bc2c8cfd6f'.

Signed-off-by: Pavel Hrdina <phrdina redhat com>
---

Pushed under trivial rule.

src/qemu/qemu_domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index dcdbfc9701..5c073027db 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -7264,7 +7264,8 @@ qemuDomainPrepareChannel(virDomainChrDefPtr channel,
                        "%s/%s", domainChannelTargetDir,
                        channel->target.name) < 0)
            return -1;
-    } else {    // Generate a unique name
+    } else {
+        /* Generate a unique name */

Oh, thanks for catching this.  You could also remove the comment
altogether since the code is pretty self-explanatory, I guess.

Unless you already pushed it, s/we // in $SUBJ.

        if (virAsprintf(&channel->source->data.nix.path,
                        "%s/vioser-%02d-%02d-%02d.sock",
                        domainChannelTargetDir,
--
2.13.3

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]