[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/7] tests: add virfilecachetest



On Fri, Jul 21, 2017 at 15:30:10 +0200, Pavel Hrdina wrote:
> Implements 3 test cases that covers how the cache is used.
> 
> We have to mock unlink() function because the caching code unlinks
> files that are no longer valid and we don't want to do it in our tests.
> 
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
> 
> Notes:
>     Changes in v2:
>         - added tests/virfilecachemock.c
>         - specify suffix for virFileCacheNew()
> 
>  tests/Makefile.am                                  |  12 ++
>  ...a15b1658aa16923e46497dd8deeb6be287ddb0ca0.cache |   1 +
>  ...ae4bc3a28e75bc3e262757001e8b953580f5e75ef.cache |   1 +
>  tests/virfilecachemock.c                           |  31 +++
>  tests/virfilecachetest.c                           | 238 +++++++++++++++++++++
>  5 files changed, 283 insertions(+)
>  create mode 100644 tests/virfilecachedata/5f3154560c130108b282a2aa15b1658aa16923e46497dd8deeb6be287ddb0ca0.cache
>  create mode 120000 tests/virfilecachedata/9ca150bf3119b75dcac8e8bae4bc3a28e75bc3e262757001e8b953580f5e75ef.cache
>  create mode 100644 tests/virfilecachemock.c
>  create mode 100644 tests/virfilecachetest.c

Reviewed-by: Jiri Denemark <jdenemar redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]