[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/24] tests: qemumonitorjson: Consolidate basic node name detection test cases



On 07/26/2017 05:00 AM, Peter Krempa wrote:
> Test cases named '1' and '2' differed only in the length of the backing
> chain, so remove test case '2' and rename test '1' to 'basic'.
> ---
>  .../qemumonitorjson-nodename-2.json                | 2270 --------------------
>  .../qemumonitorjson-nodename-2.result              |   60 -
>  ...-1.json => qemumonitorjson-nodename-basic.json} |    0
>  ...esult => qemumonitorjson-nodename-basic.result} |    0
>  tests/qemumonitorjsontest.c                        |    3 +-
>  5 files changed, 1 insertion(+), 2332 deletions(-)
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.json
>  delete mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.result
>  rename tests/qemumonitorjsondata/{qemumonitorjson-nodename-1.json => qemumonitorjson-nodename-basic.json} (100%)
>  rename tests/qemumonitorjsondata/{qemumonitorjson-nodename-1.result => qemumonitorjson-nodename-basic.result} (100%)
> 

Reviewed-by: Eric Blake <eblake redhat com>

> -      "image": {
> -        "backing-image": {
> -          "backing-image": {
> -            "backing-image": {
> -              "backing-image": {
> -                "backing-image": {
> -                  "backing-image": {
> -                    "backing-image": {
> -                      "backing-image": {
> -                        "backing-image": {
> -                          "backing-image": {
> -                            "backing-image": {
> -                              "virtual-size": 9663676416,
> -                              "filename": "/var/lib/libvirt/images/rhel7.3.qcow2",
> -                              "cluster-size": 65536,

That qemu output is rather verbose.  Here's hoping Kevin's plan to add a
saner interface in 2.11 pans out!

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]