[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/24] tests: Extract mock library for making hash table deterministic



On 07/26/2017 05:00 AM, Peter Krempa wrote:
> virHashNew calls virRandomBits to initialize seed for the hashing
> function. If a test uses iteration through the hash table to produce
> results they may/will be non-deterministic. Extract the mock library
> which was used for mac address mapping to be universal.
> ---
>  tests/Makefile.am                                     | 17 +++++++++--------
>  tests/{virmacmapmock.c => virdeterministichashmock.c} |  0
>  tests/virmacmaptest.c                                 |  2 +-
>  3 files changed, 10 insertions(+), 9 deletions(-)
>  rename tests/{virmacmapmock.c => virdeterministichashmock.c} (100%)
> 

Long name, but works for me.

Reviewed-by: Eric Blake <eblake redhat com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]