[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 19/24] tests: qemumonitorjson: Fix 'relative' node name detection test case



On 07/26/2017 05:00 AM, Peter Krempa wrote:
> Add the blockstats data and fix the expected output.
> ---
>  ...mumonitorjson-nodename-relative-blockstats.json | 329 +++++++++++++++++++++
>  ...umonitorjson-nodename-relative-named-nodes.json |  26 +-
>  .../qemumonitorjson-nodename-relative.result       |  44 ++-
>  tests/qemumonitorjsontest.c                        |   2 +-
>  4 files changed, 372 insertions(+), 29 deletions(-)
>  create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative-blockstats.json
> 

> +++ b/tests/qemumonitorjsondata/qemumonitorjson-nodename-relative-named-nodes.json
> @@ -41,7 +41,7 @@
>        },
>        "iops_wr": 0,
>        "ro": false,
> -      "node-name": "#block1177",
> +      "node-name": "#block1290",

Hmm - here you created one extra node in the regeneration in comparison
to how you set it up previously.  Not fatal to the patch, though.

Reviewed-by: Eric Blake <eblake redhat com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]