[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 1/2] make: Drop building without driver modules



On Wed, Jul 26, 2017 at 10:12:13PM +0200, Peter Krempa wrote:
> Driver modules proved to be reliable for a long time. Since support for
> not building modules complicates the code and makefiles drop the support
> for not building drivers as modules.
> ---
> 
> Notes:
>     This was suggested a while ago by Dan:
>     
>     https://www.redhat.com/archives/libvir-list/2017-March/msg00917.html
>     
>     I actually did not try to build this on windows, since I don't have the
>     environment ready (do we actually even build the daemon on windows?).

We don't build the daemon on Win32. If we did ever want todo that, Win32
has an equivalent to dlopen we could use, so modules aren't a blocker for
that.

> daemon/Makefile.am            |  57 ---------------
> daemon/libvirtd.c             |  54 +--------------
> m4/virt-driver-modules.m4     |  24 +++----
> src/Makefile.am               | 158 ------------------------------------------
> src/driver.c                  |   8 +--
> src/storage/storage_backend.c |  11 +--
> src/vbox/vbox_driver.c        |   2 +-
> src/vbox/vbox_driver.h        |   6 +-
> tests/Makefile.am             |   6 --
> tests/testutils.c             |   2 -
> tools/virsh.c                 |   3 -
> 11 files changed, 21 insertions(+), 310 deletions(-)
>

Reviewed-by: Daniel P. Berrange <berrange redhat com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]