[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/7] Misc improvements



On Thu, Jul 27, 2017 at 01:47:20PM +0200, Michal Privoznik wrote:
As I started to turn more object into using RW locks, I've found couple of
areas for improvement too.

Michal Privoznik (7):
 virConnect: Update comment for @privateData
 Report error if virMutexInit fails
 virnetworkobj: Make virNetworkObjFindBy{UUID,Name}Locked() static
   again
 virNetworkObjList: Derive from virObjectRWLockable
 virNodeDeviceObjList: Derive from virObjectRWLockable
 virConnect: Derive from virObjectRWLockable
 storageDriver: Use RW locks


The patches I have not replied to look fine, but I think it would be
easier to modify the common object after John's patches.  Are any of
those non-conflicting with those series?  If yes, I can review those
into more detail.

src/bhyve/bhyve_driver.c               |  1 +
src/conf/virnetworkobj.c               | 42 ++++++++++----------------------
src/conf/virnetworkobj.h               |  8 -------
src/conf/virnodedeviceobj.c            | 16 ++++++-------
src/conf/virstorageobj.h               |  2 +-
src/datatypes.c                        |  6 +++--
src/datatypes.h                        |  6 ++---
src/libvirt_private.syms               |  2 --
src/lxc/lxc_driver.c                   |  1 +
src/lxc/lxc_fuse.c                     |  4 +++-
src/network/bridge_driver.c            |  1 +
src/node_device/node_device_hal.c      |  1 +
src/nwfilter/nwfilter_dhcpsnoop.c      | 12 +++++++---
src/nwfilter/nwfilter_driver.c         |  5 +++-
src/nwfilter/nwfilter_gentech_driver.c |  4 +++-
src/secret/secret_driver.c             |  2 ++
src/storage/storage_driver.c           | 44 +++++++++++++++++++---------------
src/uml/uml_driver.c                   |  1 +
src/util/virerror.c                    |  2 +-
src/util/virnetlink.c                  |  1 +
src/util/virthreadpool.c               |  4 +++-
src/vmware/vmware_driver.c             |  5 +++-
src/vz/vz_driver.c                     |  4 +++-
tools/virsh-console.c                  |  4 +++-
24 files changed, 94 insertions(+), 84 deletions(-)

--
2.13.0

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]