[libvirt] [PATCH v2 0/2] Add test case for node name detection

Ján Tomko jtomko at redhat.com
Fri Jul 28 15:02:35 UTC 2017


On Fri, Jul 28, 2017 at 12:43:43PM +0200, Peter Krempa wrote:
>Patch 2/2 was originallly included in the node name detection refactor. v2 does
>not contain an ugly hack to make virTestCompareToFile, but rather fixes the
>function to treat NULL as an empty string.
>
>Peter Krempa (2):
>  tests: utils: Allow NULL strings to be equal to empty file in
>    virTestCompareToFile
>  tests: qemumonitorjson: Old and empty test case for node name
>    detection
>
> .../qemumonitorjson-nodename-empty-blockstats.json |   2 +
> ...qemumonitorjson-nodename-empty-named-nodes.json |   2 +
> .../qemumonitorjson-nodename-empty.result          |   0
> .../qemumonitorjson-nodename-old-blockstats.json   | 160 +++++++++++++++++++++
> .../qemumonitorjson-nodename-old-named-nodes.json  |   2 +
> .../qemumonitorjson-nodename-old.result            |   0
> tests/qemumonitorjsontest.c                        |   2 +
> tests/testutils.c                                  |   5 +
> 8 files changed, 173 insertions(+)
> create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-empty-blockstats.json
> create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-empty-named-nodes.json
> create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-empty.result
> create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-old-blockstats.json
> create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-old-named-nodes.json
> create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-old.result
>

ACK series

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170728/63e53745/attachment-0001.sig>


More information about the libvir-list mailing list