[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] tools: virsh: Adding unix socket support to 'domdisplay' command.



On 07/28/2017 11:49 PM, Julio Faracco wrote:
> This commit adds the unix socket URL support to 'domdisplay' command.
> Before, even if an user was using unix socket to define a spice graphics,
> the command 'domdisplay' showed that the settings were not supported. Now,
> the command shows the proper URL: spice+unix://foo/bar.sock.
> 
> Settings:
> <graphics type='vnc' port='-1' autoport='yes' listen='127.0.0.1'>
>   <listen type='address' address='127.0.0.1'/>
> </graphics>
> <graphics type='spice'>
>   <listen type='socket' socket='/tmp/spice.sock'/>
> </graphics>
> 
> Before:
> virsh # domdisplay --all Windows7
> vnc://127.0.0.1:0
> 
> After:
> virsh # domdisplay --all Windows7
> vnc://127.0.0.1:0
> spice+unix:///tmp/spice.sock
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336720
> 
> Signed-off-by: Julio Faracco <jcfaracco gmail com>
> ---
>  tools/virsh-domain.c | 52 +++++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 41 insertions(+), 11 deletions(-)

Looks good. ACK. I'll push it after the release.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]