[libvirt] [PATCH] bhyve: add support for video device configuration
Roman Bogorodskiy
bogorodskiy at gmail.com
Mon Jun 12 13:36:11 UTC 2017
John Ferlan wrote:
>
>
> On 05/09/2017 07:54 AM, Roman Bogorodskiy wrote:
> > Connect domain XML <driver vgaconf=""> configuration (introduced in a
> > previous patch) to bhyve command generation.
> >
> > Unfortunately, this option was documented just recently and at the time
> > of writing official online manpages didn't have it updated, so for now
> > one can refer to:
> >
> > https://github.com/freebsd/freebsd/blob/master/usr.sbin/bhyve/bhyve.8#L327
> >
> > for the detailed description of the possible vga configuration options.
> >
> > Also, add some tests for this new feature.
> >
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> > ---
> > src/bhyve/bhyve_command.c | 4 ++
> > .../bhyvexml2argv-vnc-vgaconf.args | 12 ++++++
> > .../bhyvexml2argv-vnc-vgaconf.ldargs | 1 +
> > .../bhyvexml2argv-vnc-vgaconf.xml | 31 ++++++++++++++++
> > tests/bhyvexml2argvtest.c | 1 +
> > .../bhyvexml2xmlout-vnc-vgaconf.xml | 43 ++++++++++++++++++++++
> > tests/bhyvexml2xmltest.c | 1 +
> > 7 files changed, 93 insertions(+)
> > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf.args
> > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf.ldargs
> > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf.xml
> > create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf.xml
> >
>
> As noted previously the xml2xml would be better served in the other
> patch. The rest seems reasonable, but obviously is affected by the other
> one... Still wanted to be sure to respond so that it's not left hanging
> without a response.
Good, I'll squash these two commits into a single one.
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170612/38594bcb/attachment-0001.sig>
More information about the libvir-list
mailing list