[libvirt] [PATCH 1/3] bhyve: tests: add vnc test to bhyvexml2xmltest

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Jun 12 14:07:30 UTC 2017


  John Ferlan wrote:

> 
> 
> On 05/09/2017 07:52 AM, Roman Bogorodskiy wrote:
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> > ---
> >  tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml | 41 +++++++++++++++++++++++
> >  tests/bhyvexml2xmltest.c                          |  3 +-
> >  2 files changed, 43 insertions(+), 1 deletion(-)
> >  create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc.xml
> > 
> 
> Looks reasonable...
> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>
> 
> John

Pushed, thanks!

> Curious - should uefi and net-e1000 also get xml2xml tests seeing as the
> xml2argv was added?


Yeah, I'll add some more xml2xml tests when I finish with the <driver>
thing.

Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170612/a69d35f6/attachment-0001.sig>


More information about the libvir-list mailing list