[libvirt] [resend PATCH v2 4/7] qemu: Implement qemuDomainManagedSaveDefineXML

Madhu Pavan kmp at linux.vnet.ibm.com
Thu Jun 22 18:13:48 UTC 2017


This commit adds qemu driver implementation to edit xml
configuration of managed save state file of a domain.

Signed-off-by: Kothapally Madhu Pavan <kmp at linux.vnet.ibm.com>
---
  src/qemu/qemu_driver.c | 41 +++++++++++++++++++++++++++++++++++++++++
  1 file changed, 41 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 5b21cf7..93c62a1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6843,6 +6843,46 @@ qemuDomainManagedSaveGetXMLDesc(virDomainPtr dom, unsigned int flags)
      return ret;
  }

+static int
+qemuDomainManagedSaveDefineXML(virDomainPtr dom, const char *dxml,
+                               unsigned int flags)
+{
+    virQEMUDriverPtr driver = dom->conn->privateData;
+    virConnectPtr conn = dom->conn;
+    virDomainObjPtr vm;
+    char *path = NULL;
+    int ret;
+
+    if (!(vm = qemuDomObjFromDomain(dom)))
+        return -1;
+
+    path = qemuDomainManagedSavePath(driver, vm);
+    virDomainObjEndAPI(&vm);
+
+    if (!path)
+        goto error;
+
+    if (!virFileExists(path)) {
+        virReportError(VIR_ERR_OPERATION_INVALID,
+                       "%s",_("domain doesnot have managed save image"));
+        goto error;
+    }
+
+    ret = qemuDomainSaveImageDefineXML(conn, path, dxml, flags);
+
+    VIR_FREE(path);
+
+    if (ret < 0)
+        goto error;
+
+    return ret;
+
+ error:
+    VIR_FREE(path);
+    virDispatchError(conn);
+    return -1;
+}
+
  /* Return 0 on success, 1 if incomplete saved image was silently unlinked,
   * and -1 on failure with error raised.  */
  static int
@@ -20856,6 +20896,7 @@ static virHypervisorDriver qemuHypervisorDriver = {
      .domainHasManagedSaveImage = qemuDomainHasManagedSaveImage, /* 0.8.0 */
      .domainManagedSaveRemove = qemuDomainManagedSaveRemove, /* 0.8.0 */
      .domainManagedSaveGetXMLDesc = qemuDomainManagedSaveGetXMLDesc, /* 3.5.0 */
+    .domainManagedSaveDefineXML = qemuDomainManagedSaveDefineXML, /* 3.5.0 */
      .domainSnapshotCreateXML = qemuDomainSnapshotCreateXML, /* 0.8.0 */
      .domainSnapshotGetXMLDesc = qemuDomainSnapshotGetXMLDesc, /* 0.8.0 */
      .domainSnapshotNum = qemuDomainSnapshotNum, /* 0.8.0 */
-- 
1.8.3.1




More information about the libvir-list mailing list