[libvirt] [PATCH] tests: Add storagevol tests for format=iso

[Pavel Hrdina]

On Tue, Mar 07, 2017 at 10:59:42AM -0500, Cole Robinson wrote:
> Demonstrates the bug fix in commit 0e5db762627
> ---
>  tests/storagevolxml2argvdata/iso-input.argv |  1 +
>  tests/storagevolxml2argvdata/iso.argv       |  1 +
>  tests/storagevolxml2argvtest.c              |  7 +++++++
>  tests/storagevolxml2xmlin/vol-file-iso.xml  | 10 ++++++++++
>  tests/storagevolxml2xmlout/vol-file-iso.xml | 11 +++++++++++
>  tests/storagevolxml2xmltest.c               |  1 +
>  6 files changed, 31 insertions(+)
>  create mode 100644 tests/storagevolxml2argvdata/iso-input.argv
>  create mode 100644 tests/storagevolxml2argvdata/iso.argv
>  create mode 100644 tests/storagevolxml2xmlin/vol-file-iso.xml
>  create mode 100644 tests/storagevolxml2xmlout/vol-file-iso.xml
> 
> diff --git a/tests/storagevolxml2argvdata/iso-input.argv b/tests/storagevolxml2argvdata/iso-input.argv
> new file mode 100644
> index 0000000..333d7e6
> --- /dev/null
> +++ b/tests/storagevolxml2argvdata/iso-input.argv
> @@ -0,0 +1 @@
> +qemu-img convert -f raw -O raw /var/lib/libvirt/images/test.iso /var/lib/libvirt/images/sparse.img

This line is too long and syntax-check isn't happy about that.

> \ No newline at end of file
> diff --git a/tests/storagevolxml2argvdata/iso.argv b/tests/storagevolxml2argvdata/iso.argv
> new file mode 100644
> index 0000000..40b99c5
> --- /dev/null
> +++ b/tests/storagevolxml2argvdata/iso.argv
> @@ -0,0 +1 @@
> +qemu-img create -f raw /var/lib/libvirt/images/test.iso 1024K
> \ No newline at end of file

For some reason both .argv files have no "\n" at the end of a file,
reported by syntax-check.

ACK with that fixed.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170308/911f6087/attachment-0001.sig>