[libvirt] [PATCH v2 2/2] conf: properly skip graphics listen element in migratable XML

Pavel Hrdina phrdina at redhat.com
Thu Mar 9 09:27:09 UTC 2017


We should skip <listen type='socket'/> only if the 'socket' path
is specified because if there is no 'socket' path we need to
keep that element in migratable XML.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1366088

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

Notes:
    Version 2:
      - no change

 src/conf/domain_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c0c1549a65..a58f997621 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -23134,6 +23134,7 @@ virDomainGraphicsDefFormat(virBufferPtr buf,
              * thus we can generate it in the migrateble XML. */
             if (def->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
                 def->listens[i].type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
+                def->listens[i].socket &&
                 !def->listens[i].autoGenerated)
                 continue;
 
-- 
2.12.0




More information about the libvir-list mailing list