[libvirt] [PATCH] domain_conf: move iothread check for address type back to qemu_command

Ján Tomko jtomko at redhat.com
Thu Mar 9 12:36:08 UTC 2017


On Wed, Mar 08, 2017 at 05:50:11PM +0100, Pavel Hrdina wrote:
>This partially reverts commit c96bd78e4e.
>

That commit also moved the check that ensures the controller type
is virtio-scsi. However, it seems qemuDomainSetSCSIControllerModel
which can also possibly set the default model to virtio-scsi
(if QEMU does not support LSI) now gets called after
virDomainControllerDefValidate.

Jan

>If an API virDomainAttachDevice(Flags) is used the device address
>is assigned after the validation and the address type may not be set.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1430275
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/conf/domain_conf.c  | 18 ++++--------------
> src/qemu/qemu_command.c | 22 ++++++++++++++++++++++
> 2 files changed, 26 insertions(+), 14 deletions(-)
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170309/0df6f4b4/attachment-0001.sig>


More information about the libvir-list mailing list