[libvirt] [REPOST PATCHv2 1/6] tests: Add createVHBAByStoragePool-by-parent to fchosttest

Ján Tomko jtomko at redhat.com
Thu Mar 9 15:27:21 UTC 2017


On Sat, Mar 04, 2017 at 10:52:07AM -0500, John Ferlan wrote:
>Add a new test to fchosttest in order to test creation of our vHBA
>via the Storage Pool logic.  Unlike the real code, we cannot yet use
>the virVHBA* API's because they (currently) traverse the file system
>in order to get the parent vport capable scsi_host. Besides there's
>no "real" NPIV device here - so we have to take some liberties, at
>least for now.
>
>Instead, we'll follow the node device tests partially in order to
>create and destroy the vHBA with the test node devices.
>
>Signed-off-by: John Ferlan <jferlan at redhat.com>
>---
> src/test/test_driver.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++--
> tests/fchosttest.c     | 64 ++++++++++++++++++++++++++++++++++
> 2 files changed, 156 insertions(+), 2 deletions(-)
>

>@@ -4406,7 +4449,6 @@ testStoragePoolCreateXML(virConnectPtr conn,
>     event = virStoragePoolEventLifecycleNew(pool->def->name, pool->def->uuid,
>                                             VIR_STORAGE_POOL_EVENT_STARTED,
>                                             0);
>-

Spurious whitespace change.

ACK to the rest.

Jan

>     ret = virGetStoragePool(conn, pool->def->name, pool->def->uuid,
>                             NULL, NULL);
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170309/d5c53db8/attachment-0001.sig>


More information about the libvir-list mailing list