[libvirt] [PATCH 05/12] qemu: Refactor Hyper-V features check

[Ján Tomko]

On Tue, Mar 14, 2017 at 05:57:44PM +0100, Jiri Denemark wrote:
>The checks are now in a dedicated qemuProcessVerifyHypervFeatures
>function.
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/qemu/qemu_process.c | 88 ++++++++++++++++++++++++++++++-------------------
> 1 file changed, 55 insertions(+), 33 deletions(-)
>
>diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>index e9631c111..48820a204 100644
>--- a/src/qemu/qemu_process.c
>+++ b/src/qemu/qemu_process.c
>@@ -3763,39 +3816,8 @@ qemuProcessVerifyGuestCPU(virQEMUDriverPtr driver,
>             }
>         }
>
>-        for (i = 0; i < VIR_DOMAIN_HYPERV_LAST; i++) {
>-            if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) {
>-                char *cpuFeature;
>-                if (virAsprintf(&cpuFeature, "__kvm_hv_%s",
>-                                virDomainHypervTypeToString(i)) < 0)
>-                    goto cleanup;
>-                if (!virCPUDataCheckFeature(guestcpu, cpuFeature)) {

Before, a failure of virCPUDataCheckFeature was ignored.

These refactors add error checking, which should be mentioned in the
commit messages.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170315/cb3eda3c/attachment-0001.sig>