[libvirt] [PATCH] cleanup: qemu_capabilities: remove redundant error messages

Jiri Denemark jdenemar at redhat.com
Tue Mar 21 09:09:22 UTC 2017


On Wed, Mar 08, 2017 at 12:14:17 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at gmail.com>
> 
> We reported error in caller qemuConnectGetDomainCapabilities.
> So the same error messages in virQEMUCapsCacheLookupByArch
> are useless.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
> ---
>  src/qemu/qemu_capabilities.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 5a3b4ac..eca46e7 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -5192,10 +5192,6 @@ virQEMUCapsCacheLookupByArch(virCapsPtr caps,
>              virQEMUCapsCacheValidate(cache, binary, caps, &ret);
>              VIR_FREE(binary);
>          }
> -    } else {
> -        virReportError(VIR_ERR_INVALID_ARG,
> -                       _("unable to find any emulator to serve '%s' "
> -                         "architecture"), virArchToString(arch));
>      }
>  
>      virObjectRef(ret);

This fix is incorrect. It's the extra error message in
qemuConnectGetDomainCapabilities which should be removed.

Jirka




More information about the libvir-list mailing list