[libvirt] [PATCH 1/3] Debug: Add WARN'ing messages for when a client has opened/closed connection.

[Peter Krempa]

On Wed, Mar 22, 2017 at 01:02:17 -0700, Prerna Saxena wrote:
> While tracing connections from a remote client, it helps to keep track
> of the connection lifecycle. Messages such as the following :
> 
> error : virNetSocketReadWire:1574 : End of file while reading data: Input/output error
> 
> are rather unhelpful. They do not indicate if the client had earlier asked for
> connection closure via libvirt API.
> This patch introduces messages to annotate when a client connected/disconnected.
> 
> Signed-off-by: Prerna Saxena <saxenap.ltc at gmail.com>
> ---
>  src/rpc/virnetserverclient.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
> index 85857bc..a77feaa 100644
> --- a/src/rpc/virnetserverclient.c
> +++ b/src/rpc/virnetserverclient.c
> @@ -678,14 +678,19 @@ int virNetServerClientGetTLSKeySize(virNetServerClientPtr client)
>      return size;
>  }
>  #endif
> -
> +/*
> + * This mostly just needs to publish the client socket FD to logs.
> + * It does not necessarily need a lock, or will add lock contention problems.
> + * Replace the lock with a reference counting mechanism, to prevent the client
> + * object from being deallocated while this is being run
> + */
>  int virNetServerClientGetFD(virNetServerClientPtr client)
>  {
>      int fd = -1;
> -    virObjectLock(client);
> +    virObjectRef(client);
>      if (client->sock)
>          fd = virNetSocketGetFD(client->sock);
> -    virObjectUnlock(client);
> +    virObjectUnref(client);

This change is not justified in any way. Also looks wrong. You can't
access an unlocked object.

>      return fd;
>  }
>  
> @@ -965,7 +970,9 @@ void virNetServerClientClose(virNetServerClientPtr client)
>      virKeepAlivePtr ka;
>  
>      virObjectLock(client);
> -    VIR_DEBUG("client=%p", client);
> +    VIR_WARN("Free'ing up resources for client=%p sock=%d", client,
> +               virNetServerClientGetFD(client));

NACK using warnings instead of debug messages is not desired. For debug
purposes you should use debug logs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170322/22b48f8d/attachment-0001.sig>