[libvirt] [PATCH v3] qemu: improve detection of UNIX path generated by libvirt

Martin Kletzander mkletzan at redhat.com
Tue May 16 09:10:00 UTC 2017


On Fri, May 12, 2017 at 05:17:33PM +0200, Pavel Hrdina wrote:
>Currently we consider all UNIX paths with specific prefix as generated
>by libvirt, but that's a wrong assumption.  Let's make the detection
>better by actually checking whether the whole path matches one of the
>paths that we generate or generated in the past.
>
>The UNIX path isn't stored in config XML since libvirt-1.3.1.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1446980
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/qemu/qemu_domain.c                             | 66 +++++++++++++++++-----
> .../qemuxml2argv-channel-unix-source-path.xml      | 29 ++++++++++
> .../qemuxml2xmlout-channel-unix-source-path.xml    | 45 +++++++++++++++
> tests/qemuxml2xmltest.c                            |  2 +
> 4 files changed, 128 insertions(+), 14 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-unix-source-path.xml
> create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-channel-unix-source-path.xml
>

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20170516/f928ddbf/attachment-0001.sig>


More information about the libvir-list mailing list